Skip to content

[Validator] Block self-references (without @nullable) in foreign keys#361

Merged
c-harding merged 1 commit intodevelopfrom
tarjan-self-loops
Apr 20, 2020
Merged

[Validator] Block self-references (without @nullable) in foreign keys#361
c-harding merged 1 commit intodevelopfrom
tarjan-self-loops

Conversation

@c-harding
Copy link
Copy Markdown
Contributor

@c-harding c-harding commented Apr 20, 2020 •
edited
Loading

Blocks the following structures from being initialised: it’s not possible to make a Foo without first having a Foo, and this isn’t Haskell 😛

Foo: service {
  foo: Foo;
}

Bar: service {
  Foo: struct {
    foo: Foo;
  }
}

Note this does not conflict with #333, as @nullable entries don’t appear in Tarjan’s graph

@c-harding c-harding requested a review from jaylees14 as a code owner April 20, 2020 12:36
@c-harding c-harding requested a review from Lewiky April 20, 2020 12:38
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2020

Codecov Report

Merging #361 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #361   +/-   ##
========================================
  Coverage    99.01%   99.01%           
========================================
  Files          136      136           
  Lines         2930     2931    +1     
  Branches        40       41    +1     
========================================
+ Hits          2901     2902    +1     
  Misses          29       29
Impacted Files Coverage Δ
src/main/scala/temple/DSL/semantics/Tarjan.scala 100.00% <100.00%> (ø)
...rc/main/scala/temple/DSL/semantics/Validator.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47b88b...b6e7be0. Read the comment docs.

@c-harding c-harding merged commit 7a1bc84 into develop Apr 20, 2020
@c-harding c-harding deleted the tarjan-self-loops branch April 20, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lewiky Lewiky Lewiky approved these changes

@jaylees14 jaylees14 jaylees14 approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-harding @Lewiky @jaylees14